Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients(extension): remove content security policy #10380

Merged
merged 1 commit into from Feb 26, 2020
Merged

clients(extension): remove content security policy #10380

merged 1 commit into from Feb 26, 2020

Conversation

connorjclark
Copy link
Collaborator

We don't need it. And FF reviewers don't like the unsafe eval bit.

@connorjclark connorjclark requested a review from a team as a code owner February 26, 2020 00:43
@connorjclark connorjclark requested review from patrickhulce and removed request for a team February 26, 2020 00:43
paulirish
paulirish approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a default CSP policy is applied for manifest 2 so we're still being safe.

@paulirish paulirish merged commit 0efa37e into master Feb 26, 2020
@paulirish paulirish deleted the extension-content-policiy branch February 26, 2020 01:30
@brendankenny brendankenny mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@patrickhulce patrickhulce Awaiting requested review from patrickhulce

Assignees

@patrickhulce patrickhulce

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@connorjclark @paulirish @patrickhulce @googlebot @devtools-bot